Skip to content

chore: migrate remaining gulp build tasks to nx#33510

Open
chaosmirage wants to merge 73 commits into
26_1from
chore/migrate-devextreme-to-nx-part-9
Open

chore: migrate remaining gulp build tasks to nx#33510
chaosmirage wants to merge 73 commits into
26_1from
chore/migrate-devextreme-to-nx-part-9

Conversation

@chaosmirage
Copy link
Copy Markdown
Contributor

@chaosmirage chaosmirage commented May 6, 2026

This PR should be merged to the 26_1 branch after #33434

@github-actions github-actions Bot added the .d.ts label May 6, 2026
@chaosmirage chaosmirage force-pushed the chore/migrate-devextreme-to-nx-part-9 branch 7 times, most recently from 33f6961 to 248a9dc Compare May 6, 2026 13:39
@chaosmirage chaosmirage self-assigned this May 6, 2026
@chaosmirage chaosmirage changed the base branch from 26_1 to chore/migrate-devextreme-to-nx-part-8 May 6, 2026 13:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

packages/devextreme-angular/project.json:127

  • The pack-npm executor no longer supports workingDirectory and runs pnpm pack from the project root, so the tarball is created in {projectRoot}/ (not under npm/dist). This target still declares outputs as {projectRoot}/npm/dist/*.tgz, which will make Nx caching/artifact tracking incorrect. Update outputs to the actual tarball location (likely {projectRoot}/*.tgz).
    "npm:pack-npm-dist": {
      "executor": "devextreme-nx-infra-plugin:pack-npm",
      "outputs": [
        "{projectRoot}/npm/dist/*.tgz"
      ],
      "inputs": [
        "default"
      ]
    },

Comment thread packages/devextreme-vue/project.json
Comment thread packages/devextreme-react/project.json
@GoodDayForSurf GoodDayForSurf requested a review from Copilot May 20, 2026 15:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated 1 comment.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated 3 comments.

Comment thread packages/nx-infra-plugin/src/utils/create-executor.ts
Comment thread packages/nx-infra-plugin/src/executors/pack-npm/pack-npm.impl.ts Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated 1 comment.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 136 out of 146 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants